-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Add Apport Symlink Hijacking: CVE-2020-8831 #20037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I've accidentally committed pushes from another module. My apologizes, I am unsure of the proper way to remove these. |
No problem; git is really awesome, but not always super intuitive. It looks like the unwanted commits are all related to your previous game overlay module.
Last, if you want, let me know and I am pretty sure I can fix it for you, but you might lose some commits. The only file you need here is |
822e526 to
68de77e
Compare
|
Yes, I only want the files relevant to this module pushed. I just added the rebase let me know if it is sufficient. |
Looks good! Let us know when you'd like us to review it. |
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
| ) | ||
| ) | ||
| register_options [ | ||
| OptString.new('WRITABLE_DIR', [true, 'A directory we can write to.', '/tmp']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For local exploit modules, this is usually registered as an advanced option:
register_advanced_options [
OptString.new('WritableDir', [true, 'A directory where we can write files', '/tmp'])
]
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
…esc.rb Co-authored-by: bcoles <[email protected]>
…esc.rb Co-authored-by: bcoles <[email protected]>
…esc.rb Co-authored-by: bcoles <[email protected]>
…esc.rb Co-authored-by: bcoles <[email protected]>
…esc.rb Co-authored-by: bcoles <[email protected]>
…esc.rb Co-authored-by: bcoles <[email protected]>
…esc.rb Co-authored-by: bcoles <[email protected]>
|
OK this is all set to go I opted to use apt hooks for the privilege escalation. Thank you to everyone for the contributes and suggestions to this module. Here is a quick run down. Before you test run these on the exploitable system: Now lets configure the exploit. I am using a bind shell because the machine is in the ☁️. Our exploit will now run on the next We'll hop back to msf and you'll find yourself with a root shell. Thank you again ! |
|
@gardnerapp sweet! Is this ready to move out of draft? |
yes |
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
|
Thanks for your pull request! Before this can be merged, we need the following documentation for your module: |
|
Thanks for your pull request! Before this pull request can be merged, it must pass the checks of our automated linting tools. We use Rubocop and msftidy to ensure the quality of our code. This can be ran from the root directory of Metasploit: You can automate most of these changes with the Please update your branch after these have been made, and reach out if you have any problems. |
|
@gardnerapp what version of ubuntu are you using and where are you getting the apport deb package? |
Wooops! You said it in the description- Xenial Xerus 16.04.7 Still curious where you got the deb package, though. |
|
@gardnerapp any update on this? |
I've been on vacation, I'll take a look tomorrow and make some changes. My apoloigies |
No problem at all. Enjoy your time off! |
gardnerapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished review
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
modules/exploits/linux/local/cve_2020_8831_apport_symlink_privesc.rb
Outdated
Show resolved
Hide resolved
Delete accidental module
|
I accidentally committed a file for another exploit please ignore. |
|
Pertinent failing test log entries: |
Which log files are you checking? When I run rubocop this is the result: |
|
I've checked the commit history of the Apport package and it looks like the vulnerable function Additionally, when a normal user runs |
This pull request is a draft for CVE-2020-8831, I originally came across this vulnerability while reading From Day Zero to Zero Day, which I highly recommend. The long story short is that certain versions of apport will follow symbolic links when writing crash dumps. This file will have a mask of 777 and be owned by root. In this module I used the command
ln -s /cron.d /var/lock/apportso that a/etc/cron.d/lockcrontab file would be created. This crontab should execute a payload every minute which was located in the/tmpdirectory.After scratching my head for several hours and combing through the log files I found that the crontab would not execute because it's file permissions were too excessive. We need to find another place for the symlink hijacking to occur. I have a few places in mind namely
/etc/init.d/or~/.bashrcwhich would trigger the payload upon startup. I am submitting this because I am unsure of which route to go or if there are other places where the symlink hijacking should occur. Thank you !